react-image-lightbox Allow Custom Content

Allow Custom Content

Open agiangrant opened this issue 5 years ago • 17 comments

This PR enables the use of custom content to take the place of an image source. This is incredible useful for display youtube videos, video files, PDFs, and placeholder elements.

Prop validation checks to see if mainSrc or mainCustomContent is given. One or the other must exist.

Custom content props are used as a fallback. If the src props are defined, then the custom content props are ignored.

Aug 15 '18 12:08 agiangrant

Pull Request Test Coverage Report for Build 77

15 of 17 (88.24%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.6%) to 43.172%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/react-image-lightbox.js	15	17	88.24%
<!--	Total:	15	17

Totals
Change from base Build 66:	2.6%
Covered Lines:	240
Relevant Lines:	561

💛 - Coveralls

Aug 15 '18 12:08 coveralls

+1 bump! This would be awesome!

Dec 30 '18 23:12 crobinson42

@fritz-c This is great PR, incredible useful for display youtube videos, video files, PDFs, and placeholder elements. Can you take a look?

Dec 05 '19 08:12 tb

@wuweiweiwu This is great, could you merge it?

Jan 17 '20 17:01 caseyjkey

+1 we would love this @fritz-c . Please prioritise.

Aug 02 '20 14:08 iamsaurabhgupt

Bueller?

Sep 26 '20 18:09 jackson-sandland

@fritz-c @wuweiweiwu anything remaining on this? please merge if all looks fine.

Sep 26 '20 21:09 iamsaurabhgupt

+1 on this one, such a simple way to do a lot :)

Nov 29 '20 17:11 jugglingjsons

We'd love to see a merge too. Currently running our own forked version with these changes and it's great. Allows us to serve our users all kinds of assets on our platform in a way that they're already familiar with.