GithubClient
GithubClient copied to clipboard
Example of Github API client implemented on top of Dagger 2 DI framework.
Why `ActivityScope` does not have `@Retention(RetentionPolicy.RUNTIME)` while `UserScope` does. Is there any good reason or just copy paste bug?
``` java.lang.VerifyError: frogermcs/io/githubclient/ui/activity/SplashActivity$AjcClosure1 at frogermcs.io.githubclient.ui.activity.SplashActivity.onCreate(SplashActivity.java:46) at android.app.Activity.performCreate(Activity.java:5231) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2148) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2233) at android.app.ActivityThread.access$800(ActivityThread.java:135) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5001) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785)...
Is the url [2.1-SNAPSHOT on Sonatype.org](https://oss.sonatype.org/content/repositories/snapshots/com/google/dagger/dagger-compiler/2.1-SNAPSHOT/maven-metadata.xml) still avaliable? How should i set "build.grale" for dagger-compiler-2.1
This is just rearrangement of the code, I totally get the point of the original arrangement, but it's not easy to find the D.I easily with the original structure. mainly...
There was an issue in SplashActivityPresenter where it was calling `splashActivity.showLoading(false);` upon button press, and this would cause an ugly occurrence in the emulator with the spinner being hidden before...
I really love your app as a model for DI for my own! Here's one design problem: Sometimes Android kills an app process in the background because of low memory....