vue-froala-wysiwyg
vue-froala-wysiwyg copied to clipboard
fix #60 - update babel & webpack
@stefanneculai this is a first cut at fixing #60, but I don't think it's quite right.
Firstly, I'll point out that it might be a sledgehammer approach - to update babel
I also had to update babel-loader
which meant I also had to update webpack
, which meant more updates...
That being said, it all builds correctly. The problem I'm coming across is that testing this in an actual Vue application isn't tree shaking vue-froala-wysiwig
correctly - it's not getting rid of the jQuery dependency (screenshots from webpack-analyser attached).
I'm not sure what has gone wrong - if it's just my dev env, or if it's actually building the module incorrectly?
Tree shaking works before update:
But not working on my PR:
@jwhitmarsh thanks for the work on this. We'll be reviewing it shortly as a part of a larger update that we're doing.
@jwhitmarsh thanks for your work on this. We just put an update on the lastest master - it would be very helpful if you could look into it and let us know if any more problems there.
Hey @stefanneculai I'm facing issues with the old corejs 2.x code in combination with node v20. Is there any chance this could be revived and loose the deprecated dependency?
What I'm seeing is
$ /build/node_modules/.bin/webpack --mode production
[webpack-cli] Failed to load '/build/webpack.config.js' config
[webpack-cli] Error: Cannot find module 'core-js/modules/es.object.define-property.js'
and froala is the last library depending on corejs 2.x
cc-ing @harasunu-narayan as they are the most active recently