angular-froala-wysiwyg icon indicating copy to clipboard operation
angular-froala-wysiwyg copied to clipboard

Publish an Ivy distribution (Angular 13+)

Open minimalism opened this issue 1 year ago • 4 comments

Using angular-froala-wysiwyg 4.0.15 in current angular (14.2.6 as of this comment - this message is most likely printed using angular 13 as well) prints the following warning during build:

⠹ Generating browser application bundles (phase: setup)...Processing legacy "View Engine" libraries:
- angular-froala-wysiwyg [es2015/esm2015] ()
Encourage the library authors to publish an Ivy distribution.

We haven't seen any actual issues with regards to functionality using this package with angular 14.

minimalism avatar Oct 17 '22 15:10 minimalism

I have this warning as well:

Warning:/node_modules/angular-froala-wysiwyg/fesm2015/angular-froala-wysiwyg.js depends on 'froala-editor'. CommonJS or AMD dependencies can cause optimization bailouts. For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

when can we have an angular 15 compatible version ?

Thanks

hocine15 avatar Jan 24 '23 14:01 hocine15

I created a pull request which build the library with Ivy. It won't fix the commonJS issues but at least you should be able to upgrade to Angular 15 (I haven't tried yet, I'm still on angular 14).

For people who don't want to use github url inside their package.json (it's very slow for me) here some steps to have a tarball inside your project.

  • git clone my fork
  • git switch upgrade-to-ivy go to the correct branch
  • npm run build build the project
  • cd dist move to the dist folder
  • npm pack create a tarball of the current folder
  • cp angular-froala-wysiwyg-4.0.17.tgz ../../my-project move the tarball inside your project
  • Update your package.json like the following "angular-froala-wysiwyg": "./angular-froala-wysiwyg-4.0.17.tgz",
  • rm -rf node_modules package-lock.json && npm i clean reinstall
  • Enjoy no more ViewEngine build error

I hope it helps someone :)

ice-blaze avatar Feb 07 '23 14:02 ice-blaze

I had problems with angular v16 so I did my own fork and upgraded up to v16 and switched to standalone components.
https://github.com/osahner/angular-froala-wysiwyg/tree/upgrade-to-ivy Thanks for the groundwork!

osahner avatar Jul 05 '23 07:07 osahner

This issue could be closed in my opinion, since Froala is in Ivy now.

ice-blaze avatar Sep 05 '23 07:09 ice-blaze