frmdstryr

Results 110 comments of frmdstryr

Looks good to me. Nice work! Copyright year should be updated and added to the header of the qt file.

Do the completer and model need to be deleted in destroy? Or does the gc handle that?

In the changeModel function it looks like they delete the whole completer. ```cpp void MainWindow::changeModel() { delete completer; completer = new QCompleter(this); // Parent set here completer->setMaxVisibleItems(maxVisibleSpinBox->value()); switch (modelCombo->currentIndex()) {...

The error when clicking the button for this ```python from enaml.core.api import Conditional from enaml.widgets.api import Window, Container, Label, PushButton enamldef MyContainer(Container): inside_my_container: Label: my_label: text = "Hello" Conditional: cond:...

I suppose the trace should actually be coming from the conditional in this case. I can't see how it's possible to get it to do that because it's coming from...

Unfortunately I don't really like how the ` DeclarativeError() from e` works... Most of the time I have to scroll up to the original error. Any ideas for an alternate...

For reasons I don't quite understand yet an error in a default value is not propagated up with this branch. Eg this is simply ignored. ```python from enaml.widgets.api import Window,...

It does nothing. What is interesting is if I raise the error in the DeclarativeError `__init__` then it gives an error. It almost seems like the exception flag somehow needs...

~~If I raise a ValueError then it works so maybe it's something with validation.~~ nevermind, doesn't matter.

Oh sorry, it's because it is doing 'pass' when DeclarativeError is raised... https://github.com/nucleic/enaml/pull/494/files#diff-68b4f23d01f700d0980fdb56a264c7bb6313fcd987739a0e7e27e9bf467d1882R189