Unofficial-BDB-Wiki icon indicating copy to clipboard operation
Unofficial-BDB-Wiki copied to clipboard

Text in images with transparent backgrounds are invisible with Github dark mode

Open bigyihsuan opened this issue 3 years ago • 2 comments

There are various images on the wiki that have transparent backgrounds but have text that is dark like the Github dark theme.

A fix would be to have a white background on these images, like other images on the wiki.

Pages Affected:

  • Vanguard
  • Redstone
  • Thor
  • Prometheus I
  • Prometheus II
  • Delta IV
  • Saturn C
  • Saturn V
  • Upper Stages
  • Crew Modules
  • GATV
  • Ranger
  • Mariner
  • Nimbus
  • Keyhole
  • Communications
  • Science
  • Shuttle-Derived Launchers

There may be more pages I've missed.

bigyihsuan avatar May 31 '21 03:05 bigyihsuan

Well that sucks. All the images with text are on transparent backgrounds. I may or may not get around to redoing them one day but it's a lot of work and the vast majority of non-regular github users will be on the default white theme.

friznit avatar May 31 '21 08:05 friznit

Isnt the dark theme the default for new users now?

Blu3wolf avatar Jan 29 '22 12:01 Blu3wolf

Opening in incognito mode shows that the default theme is dark mode:

image

It would be really nice if a white background gets added.

bigyihsuan avatar Jul 04 '24 13:07 bigyihsuan