Fritz Obermeyer
Fritz Obermeyer
It should be fine to treat this as an optional dependency ```python def summary_dataframe(self): import pandas as pd .... ```
Yes @noamsgl this would be a great first contribution! You'd need to - implement the function - add a docstring - add a smoke test (this should be easy since...
> Looks like accidentally included changes from ... No worries, #2837 should merge soon. We often add "Blocked by #xxx" in the PR description to denote merge order dependencies.
> What is missing at the moment is a simple encoder NN class. ... > is there anything already defined in pyro or a good example? Existing code includes: -...
I guess we should add a mypy test stage
This would also allow us to remove sphinx type annotations, if we were to use https://pypi.org/project/sphinx-autodoc-typehints/
Hi @kamathhrishi, sure, we'd appreciate any help! I especially like the idea of a bunch of small easy-to-review PRs that add type hints to one module at a time.
It looks like we should also [add `py.types` stub files](https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-library-stubs-or-py-typed-marker) to various directories to avoid errors like ``` infer.py:4: error: Skipping analyzing "pyro": module is installed, but missing library stubs...
This is good motivation to move enumeration tests into pyro-api https://github.com/pyro-ppl/pyro/issues/2606 I believe @eb8680 has already done much of the work as part of https://github.com/pyro-ppl/pyro/issues/2580
@kamathhrishi I believe the types are ```py def replace_param(self, param_name: str, new_param: torch.Tensor, old_param: torch.Tensor): ```