fritzing
Fix simulator issues
Adds spice fields for RGB leds and photocells Fixes potentiometer symbols Fixes a few bugs and small issues
Can you separate the PR for the schematic symbols from the simulator improvements? Or even if fixes are very related, I'd prefer smaller reviews. More than 100 files is a bit hard to handle at once. Since the merge is "all" or "nothing" otherwise good changes might delay because of unrelated minor issues.
Yes, I can do that. I will do it as soon as you reply my explanations to see if I need to change something. I thought that you could cherry-pick commits if necessary...
I will cherry-pick the commits. I think all questions have been resolved (and lets see how the ID works for now, refactoring to use something like "data-*" can be done in a separate ticket.
I just noticed a small issue. The led-rgb-6pin.fzb has the wrong moduleID. I changed it to "LEDModuleID", but it needs to be "ColorLEDModuleID" to trigger the LED code ("LEDModuleID" just triggers the capacitor code). I am attaching another commit to fix this. It is a minor thing as led-rgb-6pin.fzb has not yet SPICE info, but with this change is prepared to be simulated in the future.
I rebased this branch, and the led rgb 6 pin fix was not yet integrated: https://github.com/fritzing/fritzing-parts/tree/fix_simulator_issues