cross-unzip icon indicating copy to clipboard operation
cross-unzip copied to clipboard
verified publisher icon fritx

Breaks on non-Windows systems without `unzip` package installed

Open ghost opened this issue 7 years ago • 3 comments

Code in this project relies on the notion that if the system is not Windows, then it has CLI command unzip available. However some systems, like Manjaro Linux, don't come with unzip already installed. So cross-unzip just fails with spawn unzip ENOENT.

ghost avatar May 17 '18 03:05 ghost

@st-sloth my bad..

We could probably add more supports, like https://github.com/uiureo/node-screencapture/pull/7/files

fritx avatar May 17 '18 15:05 fritx

Dunno, I don't think depending on external tools will ever be safe anyway. https://www.npmjs.com/package/extract-zip seem to manage with just JS.

st-sloth avatar May 17 '18 16:05 st-sloth

@st-sloth yeah that would have both pros and cons.

I had been using tools implemented in pure JS before, but there would be problems like performance, so this library would be an alternative from them.

fritx avatar May 18 '18 02:05 fritx