frigoref

MessageFormat removal

3

Most cases handled via regex's MessageFormat(.format\(.*\".*)\{0\}(.*\", \w+\)) and MessageFormat(.format\(.*\n.*\".*)\{0\}(.*\") to String$1%s$2 **i18n** *.properties changed via regex (\=.*)\{0\}(.*) to $1%s$2

Fix13580 select in battle calculator

3

Should fix issue [13580](https://github.com/triplea-game/triplea/issues/13580) (Can´t select opponent in battle calculator) ## Notes to Reviewer BattleCalculatorPanel.java - new member determineUnitsOnComboSelectionChange - Constructor: Add ItemListener for comboBoxes; For swapSidesButton ensure new defender...

No return null (get territory)#1

5

*Test*.java - usage of method getTerritoryOrThrow instead of getTerritory DefaultAttachment.java - method getTerritoryOrThrow: replaces with getTerritoryOrThrowGameParseException - new methods getTerritoryOrThrowGameParseException/getTerritoryOrThrowIllegalStateException: Throwing specific exception when no territory was found - new...

**noReturnNull (getTerritory) #5** GameMap.java - method getTerritoryOrNull: Replaced by getTerritory - new method getTerritory: Returning Optional and replacing each place formerly calling getTerritoryOrNull ProSimulateTurnUtils.java - methods transferMoveMap/transferUnit/transferLoadedTransport: Use getTerritoryOrThrow instead...

Calculate size of downloaded maps when selected

3

- method newMapUrlAndSizeLabelText: Extracted logic to separate methods - new method appendSizeAndPath: Includes sum up in case multiple downloaded maps are selected - new method appendSizeAndPathSingle FileUtils.java - new method...

Avoid reparsing the RelationshipChange from a String when list is needed. Deprecate attribute relationshipChange and use new one. Ensure Serialization compatibility