Friflo.Engine.ECS icon indicating copy to clipboard operation
Friflo.Engine.ECS copied to clipboard

Arg.6 and Arg.7 Added

Open zendorx opened this issue 1 year ago • 3 comments

I have added Arg.6 and Arg.7 and plan to add 3 more up to 10. Please check my commits

zendorx avatar Jan 08 '25 15:01 zendorx

hi @zendorx,

massive work. Already wrote a comment about PR's on Discord today.

"With PR's for main repo I hesitate to merge. The main reason is I want to control the entire copyright of this project. It allowed me to change the license to MIT in the past without being blocked by a contributor for whatever reasons. I simply don't know how to handle this in GitHub without great circumstances so that it is legal flawless."

Beside this 8 Args is really enough. Other wise Signature gets too big. sizeof(Signature) == 8 For 9 args it does not fit into a 64 bit and the Enumerator gets 8 bytes bigger.

friflo avatar Jan 08 '25 17:01 friflo

Thank for the fast reply. I think it is enought to include some license for contributers to avoid that kind of problems (ex: https://github.com/coder/cla)

Any way I grant you any right for this code without any obligations from your side.

Beside this 8 Args is really enough. Other wise Signature gets too big.

In a big project it possible that query needed exclude or include more types than 8, so I think it there should be way to make it work.

zendorx avatar Jan 08 '25 18:01 zendorx

https://opensource.stackexchange.com/questions/5853/do-contributors-own-copyright-after-sending-contributions

zendorx avatar Jan 08 '25 18:01 zendorx