fop_console icon indicating copy to clipboard operation
fop_console copied to clipboard

Published 20 hours ago • verified publisher icon friends-of-presta

Split Maintenance commands

Open SebSept opened this issue 5 years ago • 4 comments

https://github.com/friends-of-presta/fop_console/blob/8a8f69f9e6b731abe16609961677e70ba42029ee/src/Commands/Maintenance.php#L29

This command handles 2 kinds of actions : change shop state & manage allowed ips for maintenance. Maybe we could make 2 separates commands.

Don't you think ?

SebSept avatar Feb 02 '20 20:02 SebSept

Yes, I agree. Should be fop:console:maintenance-ip or something.

jf-viguier avatar Feb 03 '20 14:02 jf-viguier

It doesn't really shock me since all the commands concern maintenance mode but I would be okay to split though. So it would be fop:shop:maintenance-status and fop:shop:maintenance-ip?

tom-combet avatar Sep 21 '22 10:09 tom-combet

actions are :

  • get shop maintenance status
  • set shop maintenance status
  • get shop maintenance ip
  • set shop maintenance ip

SebSept avatar Nov 04 '22 10:11 SebSept

Yep so what's the conclusion? 🤔

tom-combet avatar Nov 04 '22 11:11 tom-combet