Michael Friendly
Michael Friendly
Just checked with the new v.10.0-0. Salaries still stuck at 2016! > library(Lahman) > packageVersion("Lahman") [1] ‘10.0.0’ > summary(Salaries$yearID) Min. 1st Qu. Median Mean 3rd Qu. Max. 1985 1994 2001...
An example ER diagram or proof of concept would be welcomed
I just added a graphic of the database schema I got from Sean Lahman to the `README.md`. Maybe this is sufficient
How are you referencing the Teams data in your package? `data(Teams, package = "Lahman")` works for me.
In your code at line 146, how about `:::` `team_palette
I still don't understand the source of this problem, but you might check out how this is handled in some other packages that suggest / depend on Lahman. There is...
Thx @jestarr The Lahman package is approaching its annual update time to include more recent data and updates. We'll look at this. We always lag behind Sean Lahman's database because...
I agree that optionally allowing to retain the 0 columns is desireable, and I think the suggestion to make the quoted line conditional would do that. An argument could be...
Accepted John's changes, now in master. I've bumped the pkg version to 0.8-7, but will wait to release this. @ggrothendieck You can (after this settles down) install the github version...
@ggrothendieck @john-d-fox This change seems sensible, but I'd like to see an example of what `omit_zero_columns = TRUE` should/does look like. Does this change still work if the matrix has...