docker icon indicating copy to clipboard operation
docker copied to clipboard

Introduce Docker versioning

Open nupplaphil opened this issue 3 years ago • 3 comments

[...} New development, quick wins shouldn't be applied to stable version directly. Maybe stable version shouldn't be published from mainstream but from a tag?

You are doing a great work but it is really frustrating having an instance which could stop working at any time when my server pulls again the stable image.

Originally posted by @valvin1 in https://github.com/friendica/docker/issues/196#issuecomment-1041136954

nupplaphil avatar Feb 17 '22 20:02 nupplaphil

I'm with you @valvin1 , I try to have a look how to achieve it.

The major point which gives me headache is that we need to introduce a different versioning concept as the Friendica upstream branch. That will lead to a complex versioning matrix:

Stable Docker images:

  • upstream: stable, docker: stable
  • upstream: dev, docker: stable
  • upstream: rc, docker: stable

Staging Docker images:

  • upstream: stable, docker: staging
  • upstream: dev, docker: staging
  • upstream: rc, docker: staging

But at https://github.com/docker-library/official-images/ , we would have to tag each image unique, so like friendica:stable-stable or friendica:staging-stable or friendica:stable-dev. I'm not sure if it's understandable for Docker image users, which version causes which state :)

Another idea would be to have to different repositories:

  • friendica for the stable (official) images
  • friendica/docker for the staging (early adopter) images

I think the second would be better understandable, but we would have to maintain two repositories. Another disadvantage is the missing quality-gate of the official docker-maintainer, who are giving sometimes a lot of feedback or sometimes request changes, would be a (late) loopback into the staging branch.

nupplaphil avatar Feb 17 '22 20:02 nupplaphil

hi,

thank you for investigating this :)

isn't possible without changing the actual worklow to push to docker registry only dev version / rc ? If I've understood PR done on their repository it is an association of a tag and a specific commit of this repository? maybe you could choose to send a new commit only for dev version (or a specific version when required).

valvin1 avatar Feb 18 '22 20:02 valvin1

Oh. That's the far easiest possibility! Thanks :D I'll will adhere it

nupplaphil avatar Feb 18 '22 22:02 nupplaphil