Friedrich Gonzalez

Results 97 comments of Friedrich Gonzalez

the flag should never be disabled We need to try https://github.com/cortexproject/cortex/issues/6021 again

@tesla59 the lint needs to pass too `An error occurred while generating the doc: config=github.com/cortexproject/cortex/pkg/distributor.Config: unable to find CLI flag for 'ShardByAllLabels' config entry exit status 1`

``` pkg/ingester/limiter_test.go:228:167: too many arguments in call to NewLimiter have (*validation.Overrides, *ringCountMock, string, bool, int, bool, string) want (*validation.Overrides, RingCount, string, int, bool, string) ``` the test should compile @tesla59....

@tesla59 Just trying to guide the PR on the next step to follow. Thanks for your work so far!

The treeview feature is enabled with this https://github.com/perses/perses/issues/2420#issuecomment-2482376705

Setting up querier.query-store-after=0 is definitely a bad idea. I mentioned it in https://github.com/cortexproject/cortex/issues/5121 I think this idea helps in that regard So If I understand correctly, you could have many...

@danielblando thanks for explaining more.

@danielblando I think it should never extend to readonly on writes, even with extended writes. It's one step closer to https://github.com/cortexproject/cortex/issues/5977 what do you think?

>> @danielblando I think it should never extend to readonly on writes, even with extended writes. It's one step closer to #5977 > Its the other way around, no? we...

> double the active series this is only valid if the deployment takes less than 2 hours, because of the shipping every 2 hours. But I do I agree with...