next-routes icon indicating copy to clipboard operation
next-routes copied to clipboard

Add return statement to getRequestHandler middleware

Open dmytro-lymarenko opened this issue 5 years ago • 4 comments

This return statement should be there as that functions return promises and getRequestHandler just breaks promise chain.

dmytro-lymarenko avatar Sep 03 '18 17:09 dmytro-lymarenko

Coverage Status

Coverage decreased (-0.4%) to 94.468% when pulling 2faf867d2d72c7ef6a05a5c41a673f911cab4bc5 on dmytro-lymarenko:master into 08e8bbeaa76c5ec194abea388a193bedac7f35fc on fridays:master.

coveralls avatar Sep 03 '18 17:09 coveralls

Thanks, not sure I understand because the standard Node.js (and Express) request handler is just a function callback, no promise.

fridays avatar Sep 04 '18 06:09 fridays

@fridays, this is for koa routes. I'm using next js with koa as a custom server and I need to wait for it.

dmytro-lymarenko avatar Sep 04 '18 08:09 dmytro-lymarenko

How should I write tests so its coverage passes?

dmytro-lymarenko avatar Mar 07 '19 07:03 dmytro-lymarenko