goodtables.io icon indicating copy to clipboard operation
goodtables.io copied to clipboard

Use Etags / Last-Modified Header for GH API calls

Open amercader opened this issue 8 years ago • 2 comments

As this do not count towards the API allowance. Specially when syncing as we do lots of requests.

pygithub3 seems to have some sort of support for it but we can also use direct calls if necessary.

amercader avatar Feb 28 '17 12:02 amercader

@amercader Yes it's supported and I've discovered it on first place. It works good but one problem that this mechanism requires to persist all etags on our side. So for example an user have 500 repos so there is a need of 500 hooks iterator requests. All of this request will be having some etag we need to store somewhere.

roll avatar Feb 28 '17 13:02 roll

I was thinking a simple key/value store on redis with the hashed url and the etag

amercader avatar Feb 28 '17 14:02 amercader