frictionless-r icon indicating copy to clipboard operation
frictionless-r copied to clipboard

Specify what we need from rlang

Open damianooldoni opened this issue 1 year ago • 3 comments

In read_resource() we use the %|| operator, called the "default" or "null-coalescing" operator. It is used for the first time in L224.

This operator was first introduced in the rlang package. It was later incorporated into base R with the release of R 4.4.0.

As @peterdesmet noticed during the code sprint, we import rlang entirely: see frictionless-package.R#L4. However, by doing this it results less clear what is exactly imported from rlang.

Changing #' @import rlang with #' @importFrom rlang %||% works well: no RCMD CHECK errors with 4.3.2 and 4.4.1.

@peterdesmet: is it ok if I do a very small PR for this?

damianooldoni avatar Jul 09 '24 10:07 damianooldoni