SQL Server support

Open mpaine-act opened this issue 2 years ago • 3 comments

Overview

Looking at https://framework.frictionlessdata.io/docs/formats/sql.html I noticed that SQL Server is not supported, yet SQLAlchemy lists SQL Server CI supports version 2017. Transitively, does this mean frictionless does indeed support SQL Server but your documentation is outdated?

Please preserve this line to notify @roll (lead of this repository)

Oct 03 '23 20:10 mpaine-act

Hi @mpaine-act,

The docs note mean that we have tests specifically for Postgres/Mysql/Sqlite/Duckdb but other dialects might work as well (it's just not tested against the framework)

Oct 04 '23 12:10 roll

I see. Are these the four files that would need to be updates to test against SQL Server?

indexer/indexer.py tests/formats/sql/conftest.py tests/indexer/test_resource.py tests/formats/sql/test_parser.py

Oct 04 '23 15:10 mpaine-act

@mpaine-act It's more like replicating test for SQL Server here - https://github.com/frictionlessdata/frictionless-py/tree/main/tests/formats/sql/databases (based on one of the example)

The main challenge might be enabling it on Github Actions as I don't know if Github supports this db provider

Oct 16 '23 07:10 roll