UX feedback on 21 Feb 2019 release

[rufuspollock]

This is awesome - and functional!!

• [x] Try this "sample csv" is not clearly highlighted (i don't realise it is a link)
• [ ] have a smaller sample csv (just 30-40 lines?)
• [x] Save results in an error after logging in (perhaps i can't save to that csv?)
• [x] header of csv should be fixed if possible so i can scroll down
• [ ] make csv font/size a bit nicer
• [x] Logout seems to hover underneath top (see below)
• [x] how can i add rows? (can i add rows?)
• [ ] if i edit a cell in last row and hit enter i jump to top

[leowmjw]

Cool tool, stumbled on it while preparing for #ODD2019 this coming weekend. Would have been useful to allow non-technical users to do some simple data correction/formatting without needing to mess with git:

e.g Task: Remove extraneous rows at the end of the file: https://github.com/Sinar/odd2019/blob/master/workspace/1-head-csv/55-malaysias-export-destination/Sheet1.csv

Feedback:

1. Auto detect the file does not have permission to write, and guide user to fork the project; and the save will be a PR
2. Auto detect owner; and save will be a PR as well

[timwis]

Great suggestions! Fixed several of these issues a couple days ago but the add row business was giving me some trouble. Responses below:

Try this "sample csv" is not clearly highlighted (i don't realise it is a link)

Good point. I've made it more visible.

have a smaller sample csv (just 30-40 lines?)

Very easy to do - I used 1,000 rows to demonstrate it can handle it and scroll easily. Do you think 30-40 is more realistic or something?

Save results in an error after logging in (perhaps i can't save to that csv?)

Yeah that's because you don't have write access to that repo. #13 will make that more clear and provide an alternate route (just as @leowmjw suggested). In the meantime you can write to a repo you have write access to.

header of csv should be fixed if possible so i can scroll down

Done

make csv font/size a bit nicer

Sure, any suggestions on which font? At the moment it's bulma's default, BlinkMacSystemFont, -apple-system, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", "Helvetica", "Arial", sans-serif.

Logout seems to hover underneath top (see below)

Yeah that surprisingly difficult to fix.. going to have to dig into bulma issues. You'd think it's just a z-index thing but then you remember CSS was actually used as a torture device in the 1800s.

how can i add rows? (can i add rows?)

Yep, just right-click for the context menu. I'm curious how you would have expected to add them though -- via an empty row at the bottom? I assumed the context menu would be intuitive but perhaps it isn't.

if i edit a cell in last row and hit enter i jump to top

We can and should add a spare row at the bottom. The built-in feature of handsontable for this actually modifies the data to add an empty array, which results in a blank row being part of every diff, so I'll have to hack around that but should be easy to do.

And @leowmjw thanks for the encouragement! We'll definitely implement your suggestions (follow #13).