data-quality-cli icon indicating copy to clipboard operation
data-quality-cli copied to clipboard

Tests for generators

Open georgiana-b opened this issue 8 years ago • 1 comments

Currently the generators are not tested. Should we test them or not?

Pros:

  • The generators are using external services (CKAN) that could change and break our code. Tests would help to discover this sooner.

Cons:

  • The amount of time to run all tests would increase.
    • Devs could run all tests only at the end of the feature and execute tests independently otherwise.
    • We can require only one file type which cuts down on time.

I vote for writing tests but I might miss something. Advice is needed and appreciated.

georgiana-b avatar Jul 04 '16 14:07 georgiana-b

Great idea but i'm putting on the backlog for now.

pwalsh avatar Jul 04 '16 14:07 pwalsh