ckanext-validation icon indicating copy to clipboard operation
ckanext-validation copied to clipboard
verified publisher icon frictionlessdata

Schema editor integration

Open roll opened this issue 7 years ago • 7 comments

Control flow

  • we listen for #field-schema[-url]/[-json] changes
  • on changes we render tableschemaUI.EditorSchema with url/File/text as descriptor and onSave callback
  • user do her schema edits
  • on tableschemaUI.EditorSchema save click the component calls onSave(descriptor)
  • we set descriptor to #field-schema value

Related

  • https://github.com/frictionlessdata/tableschema-ui/issues/2
  • https://github.com/okfn/docker-ckan-unhcr/pull/6
  • https://github.com/frictionlessdata/ckanext-validation/pull/25

roll avatar Mar 15 '18 10:03 roll

Coverage Status

Coverage decreased (-0.2%) to 85.449% when pulling e70cfd441e6fc663f363dc41d711bd27ec94b65e on validation-schema into ed1c69236e8174287f1586960152fc0e7faec4cf on master.

coveralls avatar Mar 15 '18 10:03 coveralls

Coverage Status

Coverage decreased (-0.2%) to 85.449% when pulling e70cfd441e6fc663f363dc41d711bd27ec94b65e on validation-schema into ed1c69236e8174287f1586960152fc0e7faec4cf on master.

coveralls avatar Mar 15 '18 10:03 coveralls

Coverage Status

Coverage decreased (-0.2%) to 85.892% when pulling 78710aefb8909a78668ee4b0fb7fa27750cc4a5c on validation-schema into 9ce634a4dd47ed00c99b0bf3898410999320bdb4 on master.

coveralls avatar Mar 15 '18 10:03 coveralls

@amercader To run ckan with schema editor:

  • checkout docker-ckan-unhcr/pull/6
  • docker-compose -f docker-compose.val.yml up

roll avatar Apr 03 '18 08:04 roll

Known issues

  • [x] Click on X to close the modal doesn't work (does ckan has bootstrap scripts loaded?)
  • [x] Button Edit position is weird when we are changing schema via file/link/json -> #32
  • [x] Scripts/styles should be moved to proper places -> #30

roll avatar Apr 04 '18 12:04 roll

@amercader Can you please review?

I've made the user control flow changes we've discussed (an issue for the schema editing - #34). A few things which are not resolved (please help if you can):

  • [x] allow schema editing/ensuring resource editing works OK (#34)
  • [ ] moving schema buttons/inputs straight below the file button/inputs?
  • [ ] fixing tests for [email protected]/2.5 (not sure how the failures in the builds related to this changes)

roll avatar Apr 10 '18 15:04 roll

@amercader Are you able to remember what's this?)) I can't)

Have we integrated it already?

roll avatar Apr 15 '19 12:04 roll