hsr-optimizer icon indicating copy to clipboard operation
hsr-optimizer copied to clipboard

feat: optimiser relic exclusion filter

Open FI00ds opened this issue 1 year ago • 1 comments

Pull Request

Description

  • Added a per-relic filter which is toggleable, accessed via the relic modal, which allows the user to restrict which characters can use the relic in the optimiser tab
  • Added a display and filter option in the relics tab to filter/see which relics have their filter set to active/inactive
  • Added a toggle in the optimiser options to bypass the per-relic wearer restrictions
  • Updated the optimizer options tooltip with the description of the new option + made names and order consistent with the display

Not over the world with the icons but I can't think of anything that really fits

Related Issue

  • Closes #19

Checklist

  • [x] I have added commit messages that are descriptive and meaningful.
  • [x] I have tested the changes locally.
  • [x] I have reviewed the code changes.

Screenshots

Updated relic tab

firefox_2024-07-15_15-26-08

Updated optimizer options panel and tooltip

firefox_2024-07-12_17-47-16firefox_2024-07-12_17-48-19

Display on relic preview

firefox_2024-07-15_15-28-38

Selection + Toggle in RelicModal

firefox_2024-07-22_16-10-03 firefox_2024-07-22_16-11-40

FI00ds avatar Jul 12 '24 15:07 FI00ds

Holding onto this one for a bit, after trying it out it feels pretty unintuitive to use, and I suspect it might be misused by people & they'll not understand why relics aren't showing up when they should be. Probably needs a discussion about what the most user friendly way to do this is

fribbels avatar Aug 06 '24 02:08 fribbels

Closing in favour of #748

FI00ds avatar Nov 29 '24 23:11 FI00ds