[Bug] Check all conditionals for on-hit effects and exclude from combat stats

[fribbels]

Motivation

• Some buff effects are not actually combat stats, but rather trigger only on hit without adding to the character's stats. For example, crit rate buffs from Wastelander. This means our set activation might be incorrect in cases like Rutilant/etc

Updates:

• 3/21 - Set conditionals verified and fixed

Goal

• Revisit all the conditionals, figure out which ones are on-hit effects and which ones are not, then patch the damage calculations to account for this disparity. Potentially introduce a third view for Basic / Combat / On-Hit?

• [ ] Acheron

• E1 on-hit CR
• Trace 3 turn DMG

• [ ] Argenti

• Trace 15% on-hit DMG

• [ ] Arlan
• [ ] Asta
• [ ] Aventurine

• Ult on-hit CD

• [ ] Bailu
• [ ] Black Swan
• [ ] Blade
• [ ] Boothill
• [ ] Bronya
• [ ] Clara
• [ ] Dan Heng

• E1 on-hit CR (?)

• [ ] Dan Heng • Imbibitor Lunae

• Trace on-hit CD (?)

• [ ] Dr. Ratio

• Trace on-hit DMG -----------

• [ ] Feixiao
• [ ] Firefly
• [ ] Fu Xuan
• [ ] Gallagher
• [ ] Gepard
• [ ] Guinaifen
• [ ] Hanya
• [ ] Herta
• [ ] Himeko
• [ ] Hook
• [ ] Huohuo
• [ ] Jade
• [ ] Jiaoqiu
• [ ] Jing Yuan
• [ ] Jingliu
• [ ] Kafka
• [ ] Lingsha
• [ ] Luka
• [ ] Luocha
• [ ] Lynx
• [ ] March 7th
• [ ] March 7th
• [ ] Misha
• [ ] Moze
• [ ] Natasha
• [ ] Pela
• [ ] Qingque
• [ ] Rappa
• [ ] Robin
• [ ] Ruan Mei
• [ ] Sampo
• [ ] Seele
• [ ] Serval
• [ ] Silver Wolf
• [ ] Sparkle
• [ ] Sushang
• [ ] Tingyun
• [ ] Topaz & Numby
• [ ] Trailblazer
• [ ] Trailblazer
• [ ] Trailblazer
• [ ] Trailblazer
• [ ] Trailblazer
• [ ] Trailblazer
• [ ] Welt
• [ ] Xueyi
• [ ] Yanqing
• [ ] Yukong
• [ ] Yunli