hsr-optimizer icon indicating copy to clipboard operation
hsr-optimizer copied to clipboard

[Feature] Assign offsets to character portrait images for character selector/optimizer page

Open fribbels opened this issue 1 year ago • 0 comments

Motivation

Currently the character portraits are applied without offsets, which leads to some characters looking weird/standing out like Dr Ratio extending off the page

Image

Objective

  • Add in percent offsets to these images
  • The offsets should apply to the character selector linked above, and also the image on the Optimizer tab, scoring modal, anywhere else its used

Improvements

There was a lot of suboptimal stuff being done here in the rush to release. Not necessarily part of this task but just kinda noting these down before I forget

  • Images are not compressed, takes a long time to reload - need some tooling to compress/resize these automatically
  • DataParser is a giant file with all the offsets shoved in - maybe better to split these out in to the character files
  • Offsets were in pixels - should probably be percentage offsets
  • Images "jump" when their offsets shift - I've tried fixing this but its kinda hard because the css transform applies before the image loads

fribbels avatar Mar 11 '24 18:03 fribbels