hsr-optimizer icon indicating copy to clipboard operation
hsr-optimizer copied to clipboard

[Feature] Consider EHR for DoT calcs

Open fribbels opened this issue 1 year ago • 1 comments

Motivation

Currently the optimizer assumes all DoTs land for damage calculations. Which is a problem when for example if you have a higher DoT value but lower EHR value, it might actually be lower DoT damage on average because you miss your debuffs.

Objective

Similar to Crit Chance, average out the DoT column based on the chance to land a debuff on the enemy. This will probably require an additional Enemy option here for enemy effect RES

Image

And also a toggle here to disable the EHR based calc if the user wants

Image

This also means we need to go through the skill descriptions and add in the chance to land DoTs for each character and their passives

fribbels avatar Feb 15 '24 00:02 fribbels

Replace the enemy HP% selector with this slot?

fribbels avatar Feb 15 '24 11:02 fribbels

Deployed in https://github.com/fribbels/hsr-optimizer/pull/370

fribbels avatar May 24 '24 19:05 fribbels