torch-cam icon indicating copy to clipboard operation
torch-cam copied to clipboard

Update README.md

Open TommyZihao opened this issue 2 years ago • 1 comments

Add Chinese video and jupyter notebook tutorials

What does this PR do?

Closes # (issue)

Before submitting

  • [ ] Was this discussed/approved in a Github issue or a discussion? Please add a link to it if that's the case.
  • [ ] You have read the contribution guidelines and followed them in this PR.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines.
  • [ ] Did you write any new necessary tests?

TommyZihao avatar Sep 21 '22 14:09 TommyZihao

Hi @TommyZihao :wave:

Thanks for opening the PR and producing this content! Quick note on the PR though:

  • ideally, many other languages will become supported. I have to think about a maintainable structure for documentation and content across languages
  • I, for one, speak English, among others, but not Chinese. So I have no way to validate the content

If you have suggestions, I'm all ears but so far, what I've seen is in FastAPI, where Sebastian has a large community and started gradually integrating multiple languages in its documentation. Follow his example, it might be possible to go for:

  • having Chinese as an available language for the documentation
  • having Chinese versions of the notebook tutorials

But having different sources of content in a language I can't speak is hard to validate/maintain for me :/

What do you think?

frgfm avatar Sep 25 '22 18:09 frgfm