archived-bot icon indicating copy to clipboard operation
archived-bot copied to clipboard

Add command to play the first search result

Open OtterBoops opened this issue 4 years ago • 6 comments

Fixes #99

There are a bunch of stuff that can be discussed/changed:

  • The name of the command
  • A dedicated help entry
  • A lot of cleanup
  • Other misc requests

OtterBoops avatar Jun 10 '20 21:06 OtterBoops

This isn't a very clean implementation. It introduces a lot of duplicate code.

Maybe it would be better if we added this sort of functionality to PlayCommand? We could specify a flag like -1 or --first

freyacodes avatar Jun 13 '20 13:06 freyacodes

This isn't a very clean implementation. It introduces a lot of duplicate code.

Maybe it would be better if we added this sort of functionality to PlayCommand? We could specify a flag like -1 or --first

I really don't like the flag idea. In many cases, it may overlap with the actual song name in a way. How about an alias to the command, similar to sentisneks or playtop?

OtterBoops avatar Jun 13 '20 13:06 OtterBoops

Which songs could it possibly overlap with?

freyacodes avatar Jun 15 '20 10:06 freyacodes

Anything that "first" or the number 1 in the name. Ultimately it's up to you, but from my perspective, a separate alias/command is the way to go.

OtterBoops avatar Jun 15 '20 11:06 OtterBoops

You're ignoring the hyphens. We'd be searching for -1 not 1

freyacodes avatar Jun 15 '20 11:06 freyacodes

to be honest from a ux perspective making it a flag instead of a separate command seems terrible, will only cause it to not get used and flags are a bit cumbersome to use in discord i'd be in favor of using a separate command

Nanabell avatar Jun 15 '20 12:06 Nanabell