Added queue position and approx wait time. #402

[SuhanKoh]

[Shredder121]

IIRC embeds didn't look as nice. Or was it decided to do that? (Might have missed it)

[Abi45x]

We decided against embeds because they don't look as nice as the current queue

[SuhanKoh]

I have screenshots here, #402

[Shredder121]

Ok I see napster said it's okay

[SuhanKoh]

Is there another way to display long message without using embeds? The issue here is once I added queue position and wait timer, the message gets too long :/

[Shredder121]

Without embeds there is more potential screen real estate (on desktop clients*) embeds only grow as big as they do, so yeah..

[schnapster]

Embeds use a smaller font.

[schnapster]

Hi, can you provide screenshots please?

[SuhanKoh]

[SuhanKoh]

Squeezed to smallest possible on a macosx.

[schnapster]

FredBoat shouldn't use embeds where it isn't useful. Not all users see them and it is inconsistent with our other messages.

I'd like to hear your counterproposal on displaying a lot of information without bloating the messages.

[freyacodes]

I'd like to hear your counterproposal on displaying a lot of information without bloating the messages.

With a normal message, possibly less verbose than the current one

[SuhanKoh]

Should I concat the music name to maybe to x characters and replace it with "..." ?

[SuhanKoh]

How does this look?

[schnapster]

@Frederikam :eyes:

[freyacodes]

Instead of commas I would put linebreaks

[schnapster]

I think there seem to be equivalent but shorter replacements for most strings: "has been seletected" -> "selected" "position in queue" -> "position", or maybe just "queued" "approximate wait time" -> "~ wait time", or maybe "playing in"

The last "minute" is completely wrong..can probably be replaced by single letter notation (h, m, s). We might have methods for that in TextUtils already.

[SuhanKoh]

@Frederikam I think if I follow what napstr suggested, we don't need a line break. I will put up screenshots soon^tm.

[SuhanKoh]

@napstr I looked at TextUtils, is this the method you're referring to? TextUtils#formatTime

[SuhanKoh]

Any suggestion on how to put line break?

Maybe something like this?

Song selected #2 ~ Now playing
    HELLO! Songs Jukebox | Akhil Akkineni, Kalyani Priyadarshan | Vikram K Kumar | Anup Rubens (29:49) 

Song selected #1 ~ queued: #2, playing in: 29:49
    Adele - Hello (06:07)

[freyacodes]

You're right, that actually looks better

I haven't reviewed the code, but I think Napster wanted to do that

[schnapster]

I like the song name on the second line too.

[Nanabell]

I have a question. How are Livestreams handled here ?

[SuhanKoh]

@Nanabell It will now only print once for livestream. Seems like the one in production will print twice. This PR will only change the formatting of the search/selection result.

[SuhanKoh]

Screenshot for the current change:

[Nanabell]

@SuhanKoh rather meant, if there is already a live stream in the queue/playing. What does the "playing in" say when we have a live stream before it. since without a manual skip or the stream fucking up we would not play the songs after that

[SuhanKoh]

@Nanabell I just checked, it will say Queued, but the time are not added from livestream since it's live. (let me check if there is a way to detect currently playing a live stream)

[SuhanKoh]

[schnapster]

Two things:

• The "playing after livestream" message doesn't happen, when the livestream is in the queue, but not currently playing.

• Adding a track via link does not show any of the things done by this PR, but it should.

[schnapster]

More questions which you should test: What happens when a playlist/song is added

• as a youtube playlist
• as a spotify playlist
• as a hastebin link
• via ;;split