archived-bot icon indicating copy to clipboard operation
archived-bot copied to clipboard

Show position in queue after adding a song

Open schnapster opened this issue 8 years ago • 8 comments

From #suggestions by a user named Psy:

But that means the bot is not informing the position on the queue when you add music, right? It is just telling your selection there is no reference of the queue position on that notification, right? Because could be a nice addition, so you know that you added a song that is #3 on the queue list, for example

schnapster avatar Nov 18 '17 00:11 schnapster

I will work on this~

SuhanKoh avatar Nov 18 '17 02:11 SuhanKoh

One piece of info that could be shown here too is the estimated time until the song plays (as a sum of the length of those songs queued up in front).

schnapster avatar Nov 18 '17 03:11 schnapster

How does this look?

Single selection: screen shot 2017-11-24 at 10 26 19 pm

Multi-selection: screen shot 2017-11-24 at 10 26 28 pm

Single select with music currently playing: screen shot 2017-11-24 at 10 33 22 pm

Multi-select with no music currently playing: screen shot 2017-11-24 at 10 32 37 pm

SuhanKoh avatar Nov 25 '17 06:11 SuhanKoh

Nice. Embeds are probably the best way to go to condense the information onto a smaller space. What could be added to the first song, if the queue is empty:
Song #X has been selected [songname], [length], now playing

We don't have more than one queue so I think it's not necessary to call it "wait queue", just "queue" should be fine.

The screenshots are showing the same length for all songs, looks like a bug.

schnapster avatar Nov 25 '17 07:11 schnapster

Nice. Just some ideas:

  • Song queue position and the wait time could be on bold.
  • Both "approximate" and "has been" sound unnecessary. The text sounds more natural and expressive with them, but not sure if that has any point.

druellan avatar Nov 25 '17 20:11 druellan

I have reformatted based on the comments. Thanks, let me know if this is ok, I will make a PR after you guys have reviewed 👍

screen shot 2017-11-25 at 4 47 17 pm

SuhanKoh avatar Nov 26 '17 00:11 SuhanKoh

Nice, few suggestions:

  • Instead of showing (for example), 11:03 minute, can we show it as 11 minute 03 seconds or that would make the output look a bit too long?
  • Does ETA look better or misleading in place of approximate wait time: ?

owocado avatar Jul 28 '18 12:07 owocado

@thisisjvgrace

  1. Our current hours/minutes/seconds is already widely used and is internationalization friendly.
  2. "ETA" is much less common or obvious than "approximate wait time", and translators may not know what it stands for (and thus leave it as-is).

freyacodes avatar Jul 28 '18 23:07 freyacodes