archived-bot icon indicating copy to clipboard operation
archived-bot copied to clipboard

YT Alternative link doesn't parse correctly

Open knight-ryu12 opened this issue 7 years ago • 5 comments

Like, https://www.youtube.com/watch_videos?video_ids=06H_6oI4EK4&source=uberaffe This one doesn't parse as YT.

knight-ryu12 avatar Nov 03 '17 07:11 knight-ryu12

This is fixed in the lavaplayer fork we are running (in dev, hasn't hit production yet), thanks to @Shredder121's PR which is part of the fork. Hope it gets merged into upstream soon. Related links: https://github.com/FredBoat/lavaplayer/tree/fork https://github.com/sedmelluq/lavaplayer/pull/70

schnapster avatar Nov 07 '17 20:11 schnapster

Thanks.

2017/11/08 午前5:42 "Napster" [email protected]:

Closed #390 https://github.com/Frederikam/FredBoat/issues/390.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Frederikam/FredBoat/issues/390#event-1330559670, or mute the thread https://github.com/notifications/unsubscribe-auth/ALa_E86TaFpdwDcfZN6OcQ1y3JDP6InCks5s0MDCgaJpZM4QQt5W .

knight-ryu12 avatar Nov 08 '17 00:11 knight-ryu12

I don't think this one would work though. Unless the http source manager is used to resolve the redirect?

Shredder121 avatar Nov 08 '17 13:11 Shredder121

Right, disabling the http source manager breaks this.

schnapster avatar Nov 08 '17 13:11 schnapster

This issue can be fixed by doing a PR against the youtube source manager that matches these URLs

freyacodes avatar Dec 21 '17 15:12 freyacodes