archived-bot icon indicating copy to clipboard operation
archived-bot copied to clipboard

Make ;;mupdate download from CI instead of compiling

Open freyacodes opened this issue 7 years ago • 6 comments

;;mupdate and ;;mcompile are really unused by the FredBoat team as the CI server makes these commands nearly obsolete. I propose removing ;;mcompile and having ;;mupdate instead download from https://ci.fredboat.com/viewLog.html?buildTypeId=FredBoat_Build&buildId=lastSuccessful&buildBranch=%3Cdefault%3E&tab=artifacts&guest=1

freyacodes avatar Aug 09 '17 08:08 freyacodes

+1

jesgeerts avatar Aug 09 '17 09:08 jesgeerts

There are reactions now for a reason, smh

Shredder121 avatar Aug 09 '17 09:08 Shredder121

Downloading from CI would be a step back from the current functionality, where you can specify a github repository and branch from which to update from. No idea if anyone is actually using it out there though.

schnapster avatar Aug 24 '17 15:08 schnapster

Getting tons of reports of it not working

freyacodes avatar Aug 24 '17 15:08 freyacodes

When I had a go at trying to download from the ci, I kept getting a 0 byte jarfile ~~no idea if I just messed up tho~~ however I agree with napstr; the current one is much more useful if someone were to want to edit the bots code etc and I can confirm that it does work on my bot View Code. The code to dl the update is the same, just the visuals have been adjusted

Abi45x avatar Aug 24 '17 15:08 Abi45x

Currently working on creating a docker image and a self updating docker-compose config for FredBoat (keep an eye on #382 for details). Not sure if that would supersede this issue, but it's certainly worth mentioning as it achieves similar goals.

schnapster avatar Nov 01 '17 22:11 schnapster