Corey Farwell
Corey Farwell
Opened a draft PR with ASan support if anyone is curious what the changes would be like: https://github.com/georust/gdal/pull/167
> > > Why did we lose the clippy check? > > > > > > i brought back the clippy check in the latest commit, if you wanna see...
from what i understand, `num_cpus::get` [uses the affinity mask](https://github.com/seanmonstar/num_cpus/blob/23e39807636bbb06f19370a86f0a391bc798fba4/src/lib.rs#L335) whereas [`num_cpus::get_physical`](https://docs.rs/num_cpus/1.7.0/num_cpus/fn.get_physical.html) returns the unpinned physical number of cores. i might be wrong though....
It also might be good to unify language for setting the max number of threads the threadpool can start up. Maybe we should have something like: * `ThreadPoolBuilder` `fn set_max_num_threads`...
It crossed my mind that if the user needs `Clone` or `PartialEq`, the user could just wrap the `ThreadPool` in an `Arc` instead of relying on the internal one. Those...
Also, it might make sense to have `execute` and `join` return a `Result` instead of sometimes panicking.
Hey @dns2utf8, I appreciate you putting in the effort to write this proposal! Although I'm very limited on time nowadays and don't have the bandwidth to review this right now....
I'm interested in finding the simplest possible real world example. If your thumbnail generator is very simple, then yes, it sounds like it would be a good candidate.
another example: https://docs.rs/rayon/0.8.2/rayon/struct.ThreadPool.html#method.scope
~This would be pretty easy to do if we figured out https://github.com/rust-fuzz/libfuzzer-sys/issues/5~