Corey Farwell comments

Results 416 comments of


                                            Corey Farwell

Avoid `atan2` in `minimum_rotated_rect`

Do we see any path forward with the precision issues here? If not, @lnicola what do you think about converting this to a draft PR or closing it?

Panic due to integer overflow in Line::delta logic, and thus Line::slope

We can introduce `checked_delta` and `checked_slope` methods that mirror the `checked_*` methods on integers in the standard library. Would that help @jayvdb?

Add new `geo-traits` crate

Closing in favor of https://github.com/georust/geo/pull/1157

Removing (consecutive) repeated coordinates

This was completed, right?

"cargo add geo-types -F rstar" -> failed to resolve: use of undeclared crate or module `approx`

Action items here: * Add geo-types w/ rstar to our CI so this doesn't happen in the future * Decide whether to remove `approx` from that module, or require the...

Add `impl<const N, G> CoordsIter for [G; N] where G: CoordsIter`

Here's my use-case: https://github.com/frewsxcv/geo-shadows/blob/4b690d63cda7f0b1a03826b3e0c3a4108bb11fa4/src/lib.rs#L40-L43

Add `impl<const N, G> CoordsIter for [G; N] where G: CoordsIter`

Oh that's true. I also forgot that arrays coerce to slices https://doc.rust-lang.org/std/primitive.array.html > Arrays coerce to [slices ([T])](https://doc.rust-lang.org/std/primitive.slice.html), so a slice method may be called on an array. Indeed, this...

Clarify that the `triangles` method does _not_ do triangulation

It's used in our simplify algorithms: https://github.com/georust/geo/blob/2b3f7b94f4f7aa9cab65e4d2db7ff09d8bf86177/geo/src/algorithm/simplify_vw.rs#L98-L114

Clarify that the `triangles` method does _not_ do triangulation

We could rename it to `triangle_windows` to match the naming scheme of `slice#windows` (as opposed to `slice#chunks`)