Corey Farwell

Results 416 comments of Corey Farwell

Sounds good to me! I think this would be a great addition to the library! Sorry this response took so long 😬

relevant pr https://github.com/georust/geo/pull/366

Currently, I'm in favor of returning `Option`/`Result` types for methods/constructors that can return invalid geometries. At least for validation, right now, I'm envisioning something along the lines of: ```rust impl...

> The algorithm is already public, and available at [`geo::algorithm::convex_hull::graham_hull`](https://docs.rs/geo/0.16.0/geo/algorithm/convex_hull/index.html#reexports) which after the flattening PR should become `geo::convex_hull::graham_hull`. Are you thinking of further exposing this; say as another trait `GrahamHull`?...

> One question: I wrote a Well Known Binary reader/writer, and i have a method which takes a Geometry, and then write it/encodes it. The function is a big switch...

Considering the use cases people shared in this thread, and the lack of a motivating reason to remove `Geometry`, I'm going to close this

https://github.com/rustwasm/wasm-pack/pull/1102

https://github.com/rustwasm/wasm-pack/pull/1122

This issue is fixed after https://github.com/rustwasm/wasm-pack/pull/1176 merges. In particular [this binaryen upgrade](https://github.com/rustwasm/wasm-pack/pull/1136) fixed the sigsegv. Until that PR merges, you an use this command to get the fix: ``` cargo...

Uninstalled and reinstalled, still no luck. I'm cool to just merge for now, but I'm leaving it open just in case it's helpful for you to see what's going on...