Corey Farwell

Results 416 comments of Corey Farwell

> "To me, impl FromX for Y means "parse X and give me Y", and impl ToX for Y means "serialize Y as X", so FromWkt and ToWkt make sense."...

Oh I think I understand now. Sounds good to me

I've been busy the past few days, but I'll start doing the same with `rust-wkt` now that I have some free time

I've completed `impl ToWkt for geo::Geometry`. You can [see the implementation here](https://github.com/georust/rust-wkt/blob/master/src/towkt.rs). It's a little messy right now, but it'll clean up over time. Last time we spoke, this was...

@sunng87 I was thinking about that this weekend. I would love for all the readers/writers (e.g. GeoJSON, Wkt, etc) to all use the `Geo::Geometry` types internally, but unfortunately, their geometries...

An RFC merged recently that's relevant https://github.com/rust-lang/rfcs/blob/master/text/0529-conversion-traits.md

Are all the changes in this pull request isolated to `geo-types`? If so, we can just temporarily drop the `path = "../geo-types"` part in `geo`'s `Cargo.toml`, and instead just lock...

> I was thinking about limiting this PR to just the geo-types changes, but there are a lot of other places (various `Crates.toml` files) that either use a relative path...

Ugh yeah that is tricky since there's an unpublished geo-types breaking change, so we can't just release a new minor version. One option is we could release [`0.8.0-beta.0`](https://stackoverflow.com/questions/46373028/how-to-release-a-beta-version-of-a-crate-for-limited-public-testing) for geo-types...

There are two topics that need to be discussed here: - What should the trait look like? - What should the default algorithm be?