core icon indicating copy to clipboard operation
core copied to clipboard
verified publisher icon freshreader

FIX: now user can update already saved urls

Open Chhekur opened this issue 5 years ago • 2 comments

Closes #100

there are 2 changes

  • instead of having order_by in controller, I would prefer in having model as best practice.
  • now if url already exists it'll just update existing one and that on the top of the list.

Chhekur avatar Oct 07 '20 14:10 Chhekur

Thank you! I'll review this later today. 🙏

maximevaillancourt avatar Oct 07 '20 15:10 maximevaillancourt

Thank you Harendra for the contribution! It looks like tests are failing and I'm not sure why yet, I'll look into this later and take care of merging the PR once this is fixed.

I added the hacktoberfest-accepted label to the PR, so it should count towards your 4 pull requests for the month.

Thanks again! 🙌

maximevaillancourt avatar Oct 08 '20 12:10 maximevaillancourt