spook icon indicating copy to clipboard operation
spook copied to clipboard
verified publisher icon frenck

Translations update from Hosted Weblate

Open weblate opened this issue 3 months ago • 2 comments

Translations update from Hosted Weblate for Spook/Integration.

Current translation status:

Weblate translation status

weblate avatar Sep 26 '25 16:09 weblate

📝 Walkthrough

Walkthrough

This update revises translation files for Finnish, Norwegian Bokmål, and Slovak. Edits standardize phrasing, correct terminology, and improve clarity and grammar of user-facing strings. The Norwegian file introduces a new configuration section, while the Slovak file significantly expands titles and descriptions for error and entity messages to enhance user instructions.

Changes

Cohort / File(s) Change Summary
Finnish translation: String updates
custom_components/spook/translations/fi.json		 Standardizes device, area, and region terminology; refines error/repair phrasing; corrects grammar and capitalization; updates placeholder tokens in automation, group, scene, proximity, and script references; no key/nesting restructuring.
Norwegian Bokmål translation: String and schema update
custom_components/spook/translations/nb_NO.json		 Revises phrasing of various interface strings for consistency; adds new top-level "config" section containing abort and flow descriptions for setup and restart steps, introducing new keys and structured configuration guidance.
Slovak translation: Expanded descriptions
custom_components/spook/translations/sk.json		 Adds/expands detailed descriptions to several entries, especially around unknown-entity and error handling; revises user-facing entity and guidance messages; augments restart flow with more description; overall improves troubleshooting and explanatory guidance throughout file.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System (UI)
    participant Translation Layer

    User->>System (UI): Triggers error, setup, or unknown-entity flow
    System (UI)->>Translation Layer: Requests localized strings for current locale
    alt fi.json or nb_NO.json or sk.json locale
        Translation Layer-->>System (UI): Returns updated/expanded strings and config
    end
    System (UI)-->>User: Displays revised, clearer instructions/guidance in selected language

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • frenck/spook#938: Updates and additions to sk.json translations, including config and issues, closely relate to the present changes.
  • frenck/spook#910: Contains modifications to nb_NO.json and sk.json translation files with overlapping translation keys and strings.
  • frenck/spook#917: Introduces new top-level "config" sections (e.g., "abort.already_spooked") in translation JSONs similarly to these updates.

Suggested labels

maintenance

Suggested reviewers

  • frenck

Poem

Hoppity hop, in every tongue,
I tweak each phrase until it’s sung.
Sk, Fi, and No, all get a shine,
With clearer prompts and guided line.
Now users find, with less confusion,
Each hop forward brings translation fusion! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes that this PR updates translations sourced from Hosted Weblate, which aligns directly with the changes in multiple locale files.
Description Check ✅ Passed The description clearly states that the pull request contains translation updates from Hosted Weblate for the Spook integration and includes a status widget, which aligns with the actual changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3e86025e2c929a096f74b8a50cb77a6170c5222 and 6e79e95d5abe6a0ea670e7ba170ff44a489b2b10.

📒 Files selected for processing (3)
  • custom_components/spook/translations/fi.json (8 hunks)
  • custom_components/spook/translations/nb_NO.json (4 hunks)
  • custom_components/spook/translations/sk.json (6 hunks)
🔇 Additional comments (15)
custom_components/spook/translations/nb_NO.json (5)

8-8: Norwegian terminology correction looks appropriate

The change from "Omstart" to "Start på nytt" is a more standard Norwegian translation for "restart".

25-25: Improved Norwegian event terminology

The change from "Hendelse laget" to "Hendelse opprettet" is more accurate Norwegian for "event created".

31-31: Better Norwegian term for event ID

The change from "Hendelse ID" to "Hendelses-ID" follows proper Norwegian compound word formation.

95-95: Improved Norwegian translations for input helpers

The changes from "Inndata veksler" to "Binær bryter" and "Inndata knapper" to "Inndata-knapper" are more accurate Norwegian translations for "input boolean" and "input buttons".

Also applies to: 98-98

298-314: New config section with proper structure

The new config section follows the standard Home Assistant translation structure with abort and step elements. The Norwegian text appears natural and appropriate for a setup flow.

custom_components/spook/translations/sk.json (4)

183-183: Minor improvement in Slovak terminology

The change to "Diaľkový" (Remote) appears to be a minor refinement in Slovak translation.

198-201: New domain attribute and improved terminology

The addition of the "domain" attribute with "Vydavateľ vydania" (Issue publisher) and improved issue ID terminology enhance the Slovak translation completeness.

219-219: Grammar correction in Slovak question

The change from "Si naozaj istý?" to "Ste si naozaj istý?" corrects the informal/formal address usage in Slovak, which is more appropriate for software interfaces.

62-62: Use consistent ‘Vstupné’ adjective for all input helpers
The entry for homeassistant_input_select is “Vstup výberov” while others use the adjective form “Vstupné …”. Rename to e.g. “Vstupné výbery” for consistency.

custom_components/spook/translations/fi.json (6)

8-8: Consistent placeholder usage in Finnish

The change to use consistent {title} placeholders in both the fix_flow step and main title follows proper translation structure.

Also applies to: 12-12

15-107: Comprehensive Finnish translation improvements

Multiple improvements in Finnish translations including:

  • Better terminology for various Home Assistant concepts
  • Consistent use of "ongelman" (problem) vs "vian" (error) throughout
  • Improved grammar and natural flow

The changes appear well-researched and consistent across the file.

116-117: Finnish entity name improvements

The translations for datetime entities and alarm control panels are more accurate in Finnish.

Also applies to: 119-119

218-218: Improved Finnish terminology for input helpers

The changes to device tracker terminology and various input helper names reflect better Finnish localization practices.

Also applies to: 233-233, 239-246

280-281: Better Finnish translation for repairs button

The change from "Neignoroi kaikki" to "Poista kaikki sivuutukset" is more natural Finnish for "unignore all".

317-328: Improved Finnish config flow messages

The updated configuration flow descriptions in Finnish are more natural and user-friendly.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Sep 26 '25 16:09 coderabbitai[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Sep 26 '25 16:09 sonarqubecloud[bot]