python-wled
python-wled copied to clipboard
frenck
⚪ Missing CCT support
With popular strip chips like FW1906 hitting the market with RGBCCT leds support and with WLED properly supporting CCT channel from version 0.15 we really need CCT support in python-wled as well.
This would allow adding those kind of strip to home assistant as well, because as for now it's not possible to add them (if cct strip is detected the config flow is being stopped) https://github.com/Aircoookie/WLED/pull/3298#issuecomment-1865819890 and https://github.com/home-assistant/core/issues/101029#issuecomment-2011171564
This was already asked here: https://github.com/frenck/python-wled/issues/977
Moreover, a PULL request was already made (I was going to implement basically the same before checking for existing PRs): https://github.com/frenck/python-wled/pull/1137
It was closed by bot for stale, but please consider merging it to allow me opening a PR to home assistant adding support for CCT strips, thank you.
@frenck bumping again, how we are supposed to maintain the home assistant integration if this package doesn't get any attention?
Thanks @Suxsem for raising this issue. I am a newcomer to the HA ecosystem - have been building out my IoT network at home with the use of this great piece of software. I arrived to this Github thread trying to find out a way to fully exploit my Athom bulbs and I just wanted to show my support for the CCT support in HA. @frenck would appreciate if you can have a look! Best
@frenck what do you need to keep going with the maintenance? PRs? collaborators? maintainers? donations? It's a shame a popular project such as WLED cannot get updated home assistant support. Please, tell us how to ensure this project is properly maintained, I'd really like a reply, thanks a lot
@frenck : i just found out about the missing cct support and I would appreciate if you can work on this (or at least give some feedback how we could help you) because I now have installed WS2805 led strips and would love to make it work with home assistant (Y) Hope of hearing from you soon! 👍
@frenck : i just found out about the missing cct support and I would appreciate if you can work on this (or at least give some feedback how we could help you) because I now have installed WS2805 led strips and would love to make it work with home assistant (Y) Hope of hearing from you soon! 👍
same here, @frenck i would really like this integration!
Maybe we just have to create fork and make it custom component available in HACS?
@frenck : i just found out about the missing cct support and I would appreciate if you can work on this (or at least give some feedback how we could help you) because I now have installed WS2805 led strips and would love to make it work with home assistant (Y) Hope of hearing from you soon! 👍
same here, @frenck i would really like this integration!
I've shipped some updates recently, currently looking into adjusting the models to support this. Progress can be tracked in #1334
@frenck any progress? Why not simply merging https://github.com/frenck/python-wled/pull/1137 ?
If the library is unmaintained, that's fine. Just fork it, create a new pypy library, merge the code and move the HA integration to depend on the forked library.
I know but it's not really clear if it's manained or not. It's seems to not be actively maintained, but it can happen that for some period one it's too busy with other things. This is why I would appreciate if the owner could be more clear with its intentions with this project. I have some spare time and I would offer to maintain the library as a collaborator but we need some kind of proper discussion with @frenck
@frenck any progress? Why not simply merging https://github.com/frenck/python-wled/pull/1137 ?
By because there are more things to handle than just cct support.
@frenck any progress? Why not simply merging #1137 ?
By because there are more things to handle than just cct support.
Cct support and improved ota updates are the most (maybe only) requested features for this library, maybe it's worth focusing on those in order to make them available in the short term and then rewrite the library for other goals, what do you think?
@frenck any progress? Why not simply merging #1137 ?
By because there are more things to handle than just cct support.
Cct support and improved ota updates are the most (maybe only) requested features for this library, maybe it's worth focusing on those in order to make them available in the short term and then rewrite the library for other goals, what do you think?
Sorry, do not agree. That is hard to do Without making a hot exception mess, mostly caused by slightly different handling @ wled end in different versions.
@frenck do you mean differences between 0.14 and 0.15 or between different variants (eg. Audio reactive)? That said, do you plan to work on the project during the following weeks? Would you like a collaborator? We could open a discord server to coordinate developments. The problem here is that CCT users are basically left with no home assistant support, and nowadays more and more strips are becoming cct, this is why I would like to add support in a short term, like a month or so
do you mean differences between 0.14 and 0.15 or between different variants
The behavior of CCT, color modes, OTA, and much more has been different between every single version since WLED 0.8.4 and now.
That said, do you plan to work on the project during the following weeks?
I have no plan, this project is not my job, but a side project.
Would you like a collaborator?
You haven't seems to try to contribute anything at this point:
I know you offered help, which is welcome. But I won't be adding collaborators with write access to projects that are unknown to the project.
We could open a discord server to coordinate developments.
Not understanding why that is needed, GitHub suits fine.
The problem here is that CCT users are basically left with no home assistant support
Yup. As it has many issues in the past. Nowadays, it is better. Had a little talk with Aircoookie, when I met him a few week ago as well; it is time for a proper translations of color modes (not just CCT).
this is why I would like to add support in a short term, like a month or so
So, CCT has not been supported since years, I don't understand the rush part behind this? If it is done in a week, great! Done in two months fine, done in three months from now: still great! Wonder how you came up with the "month" time frame and the rush you put behind this?
@frenck no rush nor time frames, the PR I linked consists very little modifications, I tested it and worked great with a slightly modified version of the wled HA integration. I'm a professional software engineer and part of my job consists in estimating developing tasks, a month seems to me a good estimation for a side project if there is commitment. I perfectly understand that all your work is voluntary but it's a fact that both wled and home assistant are very popular open sourced projects and having a maintained integration (and to me this also means having a plan of upcoming work, best of public) is very important for a lot of people. As I said, no one is asking you to do any free or paid work, just it would be great to have a clear view of the future of this project and, besides forks, what is the best way to support you in developing the requested features. If you prefer to not giving write access it's perfectly fine, just what's the best way, if any, to help.
the PR I linked consists very little modifications
That is where we are not in agreement. If you just focus on the latest version, Yup, that will work in a way (ignoring historical versions, which we either should A) not ignore or B) deprecate); but it will need more on the HA side to handle the color modes correctly (which ain't correctly right now either).
Hi @frenck, I see your recent commits, looks promising. Do you think the code is stable enough for me to make a PR in order to support this or do you plan to make other relevant changes?
Do you think the code is stable enough for me to make a PR in order to support this or do you plan to make other relevant changes?
The first step right now, it to get HA upgraded. I've just finished manual testing on that end, but I need to adopt the unit tests.
Nevertheless, feel free to open a PR; but I'll hold it for merging for a bit (until I've got downstream tackled).
Hi @frenck, has been a while, any news? Did you have a chance to have a look to the PR?
@Suxsem The PR isn't relevant yet, as mentioned above, downstream needs to be tackled first now.
I've been slowly progressing at that, the first base PR is now open downstream: https://github.com/home-assistant/core/pull/122101
../Frenck
@frenck great! What plans do you have to add support upstream (home assistant)? Do you like me making a PR to add support or do you prefer to do that yourself?
@Suxsem I did bump the upstream version, I haven't build in support for it. Feel free to do so!