python-adguardhome
python-adguardhome copied to clipboard
frenck
Feature: Client Resources
- added getters for the list of client / autoclient / supported tags resources
Proposed Changes
Adding support for the Client / AutoClient resources in AdGuard Home
The first commit here is to open discussion on structure and naming; if this is desirable in this state, I will add the update operations to it as well.
I don't intend to get super clever with remote ORM stuff here; I only want to have simple "add", "update", "delete" methods for them that refer to the APIs directly.
Related Issues
(Github link to related issues or pull requests)
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
No Coverage information
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I'll ping too. Please test/merge this. I'd like to use it upstream with HomeAssistant
@bendalton and @offbyone
I hate to break it to you but, Frenck mentioned in a HomeAssistant PR, that he doesn't expect to do maintenance on this library in the short-term.
See: https://github.com/home-assistant/core/pull/83505#issuecomment-1342296729 for more information.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
No Coverage information
0.0% Duplication
I'll ping too. Please test/merge this. I'd like to use it upstream with HomeAssistant
I hate to bring it to you, but if you goal is to use this in Home Assistant: You can't.
To make this possible, we need an identifier. A request for this is open @ the AdGuard Home team.
So, if that is your only goal, I suggest closing this PR as it has no foreseeing future.
Sorry I now realize I responded to a non-author, sorry about that 👍
../Frenck
Okay; I'll add update methods here as well and then update the PR. Thanks.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
I'm still interested in merging this, just haven't had the time to finish it up.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
4 Code Smells
No Coverage information
0.0% Duplication
@frenck I'm not able to label it in a way that'll let the PR labels workflow pass; could you do that?
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
I am still interested in merging this, I just need the maintainer to okay it.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
I am still interested in merging this, and waiting for @frenck to label it and approve it.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
Yup, still interested. @frenck are you maintaining this library any more? If not, can I have the PyPi keys and I'll start publishing it?
I still have plans, right now, I am traveling (for a few weeks to come still).
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.