python-adguardhome icon indicating copy to clipboard operation
python-adguardhome copied to clipboard

Added support for the DNS rewrite rules AdGuard API

Open finnhartshorn opened this issue 5 years ago • 5 comments

Adds support for adding, deleting and listing DNS rewrite rules via the Adguard Home API

finnhartshorn avatar Sep 13 '20 05:09 finnhartshorn

Codecov Report

Merging #172 (a4bf244) into main (b72f80b) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   99.10%   99.17%   +0.06%     
==========================================
  Files           8        9       +1     
  Lines         224      242      +18     
==========================================
+ Hits          222      240      +18     
  Misses          2        2              
Flag Coverage Δ
unittests 99.17% <100.00%> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adguardhome/adguardhome.py 97.70% <100.00%> (+0.05%) :arrow_up:
adguardhome/rewrite.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b72f80b...a4bf244. Read the comment docs.

codecov[bot] avatar Sep 13 '20 05:09 codecov[bot]

Would totally love this PR! I'm missing this today with my puppet and fabric management of the environment here home.

mr-awk avatar Sep 14 '20 14:09 mr-awk

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Mar 11 '21 08:03 github-actions[bot]

I vote for this merge. I did have to modify the three requests in rewrite.py to self._adguard.request. Would submit a pull request, but would rather @finnhartshorn get the credit for the contribution.

copart avatar Oct 23 '22 01:10 copart