Franck Nijhof

Results 1182 comments of Franck Nijhof

I understood. The problem is that PR removes the occurrences from `core_brands`, however, core relies on it.

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale. Feel free to re-open this PR when you...

> > I think this is now seen as an entity platform, so i dont think we should move it from init > > I think that even for entity...

> Anyway, happy to close, and keep the pylint ignore in there for now. There is no ignore needed here; this is an entity component which we can detect upfront.

Yup! https://github.com/UI-Lovelace-Minimalist/UI/releases/tag/v1.3.10

The test failure is not related to this pull request. Will continue with the merge. ../Frenck

I've marked this PR a draft, as changes are requested that need to be processed. Please un-draft it once it is ready for review again by clicking the **"Ready for...

> If you aren't the current code-owner of this add on would you please address this to the right peoples? I'm confused by this comment. The add-on is maintained and...

Thought, maybe needs its own rule, but DHCP based update of config entry based on known device based discovery?

> Isn't that already built into the dicovery? Yes/no. DHCP device based discovery works a tiny bit different. As in, it doesn't work by discovery on stuff in the integration...