workbench icon indicating copy to clipboard operation
workbench copied to clipboard

Published 20 hours ago • verified publisher icon fremantle-industries

Build release in Dockerfile

Open ghost opened this issue 3 years ago • 3 comments

I had a look at the Dockerfile and I suggest using mix release instead of copying everything and building. I can do it, tell me if that's interesting you.

I also suggest publishing a version to hub.docker.com for ARM and x86.

ghost avatar Sep 03 '20 14:09 ghost

Heyo @steffenix 👋

The current docker + compose setup is targeted at development but I think it's a good call to have a prod one also and use mix release. Do you mind creating a PR?

What's your thoughts on:

  • Rename the current Dockerfile to Dockerfile.dev
  • Create a new Dockerfile the builds the app with mix release
  • Use Dockerfile.dev in the build context of docker-compose.override.yml
  • Use Dockerfile in the base docker-compose.yml

rupurt avatar Sep 04 '20 01:09 rupurt

@steffenix I made some improvements to the docker setup in https://github.com/fremantle-industries/workbench/commit/e5894cdd73e259045bfedbeb81758c2b101b9165

The second layer could now build using mix release

rupurt avatar Nov 15 '20 23:11 rupurt

I have put this on pause but I have pushed and opened a PR it's WIP, I have some issues with the JS assets.

https://github.com/fremantle-industries/workbench/pull/169

ghost avatar Nov 16 '20 09:11 ghost