gluon icon indicating copy to clipboard operation
gluon copied to clipboard

Config-Mode UI for Interface Role Assignment

Open lemoer opened this issue 2 years ago • 7 comments

First steps towards https://github.com/freifunk-gluon/gluon/issues/2393.

Next steps:

  • [x] Allow creation of vlan interfaces.
  • [x] Allow deletion of vlan interfaces.
  • [ ] Allow expanding /lan, /wan, /single interfaces.
  • [ ] Create sections for additional ethernet interfaces in /etc/config/gluon if they do not exist.
  • [x] Make Uplink and Client role mutually exclusive.
  • [ ] Test this with a DSA device.
  • [ ] Test what happens if we create vlans on swconfig interfaces.
  • [ ] Maybe forbidd creating vlans on swconfig interfaces.
  • [ ] Readd i18n.

lemoer avatar Apr 15 '22 00:04 lemoer

@lemoer I'm working on implementing the bridge isolation feature for mesh links (https://github.com/freifunk-gluon/gluon/pull/2484) and @AiyionPrime suggested that I mention it here as those features are related to the same issue.

belzebub40k avatar Apr 20 '22 18:04 belzebub40k

Currently this PR looks like this: image

lemoer avatar Apr 21 '22 21:04 lemoer

Currently the workflow to create a VLAN looks like this:

lemoer avatar May 05 '22 23:05 lemoer

Roles "Uplink"/"Mesh" and "Client" are now mutually exclusive:

lemoer avatar May 06 '22 02:05 lemoer

I will continue working on this, when #2526 is merged/discussed/decided.

lemoer avatar May 21 '22 23:05 lemoer

Discussion from the gluon dev meeting 2022-03:

  • Maybe build the UI without adding a possibility to expand /lan, /wan and /single interfaces in the first place.
  • In the second instance:
    • By default, /lan refers to lan1, lan2, lan3, lan4.
    • If an interface for lan1 is defined, then:
      • lan1 is removed from /lan.
      • So this means that /lan only refers to lan2, lan3, lan4.

lemoer avatar Jun 14 '22 20:06 lemoer

Looks nice! I'm wondering if there should be some warning + explanation from the UI if the user selects uplink + mesh on an interface. I assume that users are usually not aware why/when this configuration could make their WiFi experience incredibly slow.

T-X avatar Aug 11 '22 11:08 T-X

In order to simplify things, this is closed in favor of https://github.com/freifunk-gluon/gluon/pull/2688.

lemoer avatar Oct 30 '22 19:10 lemoer

I assume that users are usually not aware why/when this configuration could make their WiFi experience incredibly slow.

@T-X : I do not really understand? This PR is only about the configuration of wired interfaces. How does this influence the WiFi experience?

lemoer avatar Oct 30 '22 19:10 lemoer

@lemoer it'll influence the WiFi experience when someone uses a standard home router on the uplink side which also has WiFi enabled. Which I guess is a typical scenario? If then using the uplink+mesh roles at the same time then the home wifi router will usually send all the layer 2 broadcast and routing protocol management packets at a slow 1MBit/s wifi bitrate. Depending on the overall mesh network size this could lead to high airtime usage on whatever channel the home router uses.

But anyway, we had the "mesh-on-wan" checkbox before, ready to use in parallel with mesh-vpn. So wouldn't be a "regression", was just wondering if there could be an easy way to give a hint about that potential issue while the UI is updated.

T-X avatar Oct 31 '22 08:10 T-X

@T-X This is an important point. Can you maybe open an issue for this so it doesn't get lost?

lemoer avatar Nov 17 '22 10:11 lemoer