gluon
gluon copied to clipboard
Feature responsive
make the design more responsive:
- border-radius, margin-and padding, use short-hands
- error-message: with padding & font-weight
- no bottom padding for fieldset.gluon-section
- rem and not em, min partial is 1/8
- duplicates removed
- responsive display optimized: flex-displays and margins
- definitions joined and encapsulated -> this is scss not only css!
- initial viewport-scale and -width
- break-word for long titles and values (pubkey!)
- add .editorconfig-entry for scss-files
This looks like lots of useful changes, but it would be much easier to review if each of the points you list in the commit description were a separate commit... I'll still have a short look and comment on a few things I notice.
Thanks for the fixes.
I don't know how familiar you are with Git, but if possible, the commits should still be reorganized (you can replace the PR using a force push after squashing and separating commits).
This looks like a lot of work, to separate into so many commits, because there are so many CSS rules changed. And the benefit of separate commits are marginal.
I would suggest to just figure out the pages that are effected and check if it all looks fine now. And then squash this into one commit.
@wolf128058 If you want to get this moving again, just mention me, or reply to my mail and we can get this done in an afternoon, or so.
I tested this and think that we should merge this (after fixing the color):
copying the above gluon.css into /lib/gluon/config-mode/www/static/gluon.css
this is the result:
instead of the old one:
I think this is a huge benefit which should not be just closed.
@maurerle I like his changes as well. The form he submitted was just not reviewable and after a year of waiting on any answer, as well as the reminder a month ago which was left unanswered I think it was fair to close it, to make room for other contributors, like yourself.
If you want to start working on this, I suggest you checkout the commits and rebase it on your own branch and open a new PR referencing this. As long as you work with his commits, make sure to be a good sport and use a "Co-authored-by: " line, so that you both can be credited for this.
Looking forward to your contribution :)