gluon icon indicating copy to clipboard operation
gluon copied to clipboard

libpcap: Add support for B.A.T.M.A.N. Advanced

Open T-X opened this issue 2 years ago • 4 comments

This adds support for the layer 2 mesh routing protocol B.A.T.M.A.N. Advanced. "batadv" can be used to filter on batman-adv packets. It also allows later filters to look at frames inside the tunnel when both "version" and "type" are specified.

Documentation for the batman-adv protocol can be found at the following locations:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/batman-adv.rst https://www.open-mesh.org/

Signed-off-by: Linus Lüssing <[email protected]>


This is a requirement for the gluon-statistics-mcast package and eases batman-adv network debugging in general. A pull-request to upstream libpcap is pending and has gone through some first rounds of reviewing here:

https://github.com/the-tcpdump-group/libpcap/pull/980

T-X avatar Jan 01 '22 12:01 T-X

It seems that the upstream PR needs to be rebased again...

neocturne avatar Jan 24 '22 21:01 neocturne

Changelog v2:

  • updated to OpenWrt 22.03 / libpcap 0.10.1

It seems that the upstream PR needs to be rebased again...

Thanks for the remark. Had updated the upstream PR on the 26th January right after your remark. (Still no one at libpcap/tcpdump has merged it yet though, even after another half a year gone... but @AiyionPrime was so kind to poll on the upstream PR again)

T-X avatar Jun 26 '22 19:06 T-X

Changelog v3:

  • rebased to current Gluon master: moved libpcap patch from 0004-... to 0006-...

T-X avatar Jun 26 '22 22:06 T-X

Changelog v4:

  • rebased to current Gluon master: moved libpcap patch from 0006-... to 0007-...

T-X avatar Jul 07 '22 22:07 T-X

it's been 2 years since the upstream pr had any comment, what should we do?

Djfe avatar Jul 17 '23 06:07 Djfe

We wait. @T-X resolved the issues partially by getting it merged into OpenWrt;

and "two years no comment" is not true; I commented in late april and @fxlb rebases the upstream PR on a regular basis and requested reviews; the last one was only a week ago.

Maybe he has more insights, why the PR is so troublesome, but I'd say they are at least partially working on it and there is no need for us to nag about it.

AiyionPrime avatar Jul 17 '23 13:07 AiyionPrime

I read it as April 2021 🙈

Djfe avatar Jul 17 '23 14:07 Djfe

The Patch seems to have been upstreamed and is available with openwrt-23.05 and therefore Gluon master: https://github.com/openwrt/openwrt/blob/openwrt-23.05/package/libs/libpcap/patches/300-Add-support-for-B.A.T.M.A.N.-Advanced.patch

herbetom avatar Oct 10 '23 19:10 herbetom