gluon icon indicating copy to clipboard operation
gluon copied to clipboard

gluon-mesh-babel: Reduce load in respondd

Open christf opened this issue 5 years ago • 6 comments

This reduces the load by:

  • querying the default route using netlink instead of parsing it from babel
  • instead of dump, use monitor and a separate thread to obtain the babel neighbours
  • [ ] resolve TODO in a different PR this on is meant to fix a problem: include traffic stats for all mesh interfaces

christf avatar Aug 23 '19 17:08 christf

i just noticed that this PR contains parts that are not directly related to "reduce load", maybe you can split this apart and get parts merged faster and also reduce this PR's size?

rotanid avatar Sep 29 '19 17:09 rotanid

@t-8ch thank you for your review. Were all of your comments considered as intended?

christf avatar Oct 16 '19 19:10 christf

unfortunately libjson-c 0.13 is not yet in relevant gluon versions for a while. only 0.13 includes json_object_deep_copy(). Because of this I introduced a fallback that should work with 0.12. Testing is in progress.

christf avatar Nov 01 '19 23:11 christf

this needs a rebase now @christf ... and somehow it's still missing a review with C+Gluon skills after that :(

rotanid avatar Jan 17 '20 21:01 rotanid

rebase is done.

christf avatar Jan 20 '20 21:01 christf

See https://github.com/christf/libbabelhelper/pull/9 for current progress on libbabelhelper cleanup.

neocturne avatar Mar 14 '20 15:03 neocturne

@christf needs rebase?

rotanid avatar Dec 18 '22 20:12 rotanid

Closed because of #3105

blocktrron avatar Jan 07 '24 22:01 blocktrron