spa-rs icon indicating copy to clipboard operation
spa-rs copied to clipboard
verified publisher icon frehberg

Fix sunrise/sunset calculation for timestamps before 12:00 UTC

Open granddaifuku opened this issue 1 year ago • 1 comments

Resolves #8

Problem Overview

Since the Julian Day starts at noon, truncating the Julian Day before 12:00 UTC results in the sunrise/sunset being off by one day.

Example

・September 30, 2005 UTC 12:00:00
jd = 2453644.0
jd (truncated) = 2453644

・September 30, 2005 UTC 11:59:59
jd = 2453643.999988426
jd (truncated) = 2453643

granddaifuku avatar Aug 25 '24 12:08 granddaifuku

@frehberg Hi! This is just a gentle ping about the PR. It would be really grateful if you could take a look at this PR as it relates to the issue https://github.com/wez/wezterm/issues/5847. Thanks in advance!

granddaifuku avatar Nov 27 '24 11:11 granddaifuku