fregie

Mine. UDP Listener shouldn't use tcp listener's local addr.

1. UDP local address may be different with TCP local address 2. In my implement,UDP local address will use the IP that assigned by `WithBindIP` in `option.go`.I'm not sure this...

Return the local addr that tcp listener used may work,but it is just a coincidence.What if the server is behind NAT? That will return a intranet address not working to...

No,you need to assign the right udp addr when you define the server options,and it will work well with all socks5 client. Like this: ```go opts := []socks5.Option{ socks5.WithBindIP(udpip), }...

Socks5 is a protocol.I don't think we should fix it incorrect to make it compatible with incorrect implementation of clients

I understand what you mean.There is two conception we discussing. First is the UDP IP return to client. Second is the local addr to listen. In logic,this two thing is...

I have told you,bindIP is only for assign udp ip for return to client If you assign a 0.0.0.0 to bindIP,what's wrong with you?

Yeah,but that's a para error

You didn't get my point,I won't reply you any more. I stand by my opinion: UDP listening on the same addr with tcp or `0.0.0.0`,and return the `bindIP` to client

Both implementation is not good enough for now,I don't care who's PR is accepted. But I think the plan should be what I said above,if it's need,I can't fix my...