object-fit-images icon indicating copy to clipboard operation
object-fit-images copied to clipboard

Published 20 hours ago • verified publisher icon fregante

Dont't fix image with empty src

Open bpahan opened this issue 7 years ago • 2 comments

I have faced with extra reqeust in IE and after investigation I noticed that ofi generates them.

I use tag image without src attribute at all (or it can be image with empty src) for lazy loading. In that case ofi process this image and create backgroun-image style with empty source which make new request to current page.

Could you suggest the desicion for this case?

bpahan avatar Aug 30 '17 13:08 bpahan

Hi @fregante, I saw that this bug is still open and that there is a brach with the fix in it. I and my team are using your awesome polyfill, but in order to make it work properly, we are currently applying a patch like the one you merged here. We were wondering why this is not been merged in master and released with a new version.

Can I do something to help with it? Thanks 😁

matteobad avatar Sep 29 '20 14:09 matteobad

I haven't merged it because I don't have time to test it properly on IE and don't want to break it for anyone who has been using it unchanged for the past 3 years.

If you'd like to help, you can test it on IE9, IE11 and let me know if it works on both:

  • does the demo still work correctly in both browsers?
  • does it work if you add the src after?

fregante avatar Oct 01 '20 21:10 fregante